Skip to content

[SPARK-52082][PYTHON] Improve ExtractPythonUDF docs #50867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SPARK-52082][PYTHON] Improve ExtractPythonUDF docs #50867

wants to merge 1 commit into from

Conversation

benrobby
Copy link

What changes were proposed in this pull request?

  • renames two methods in ExtractPythonUDFs, and adds docstrings explaining the parallel fusing and chaining concepts

Why are the changes needed?

  • in my experience, new developers find the planning code hard to understand without sufficient explanations. The current method naming is confusing, as the canChainUDF is actually used select eligibility to fuse parallel udf invocations like udf1(), udf2().

Does this PR introduce any user-facing change?

  • No

How was this patch tested?

  • Existing tests

Was this patch authored or co-authored using generative AI tooling?

No

@benrobby
Copy link
Author

Hi @ueshin, could you take a look at this minor change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon Awaiting requested review from HyukjinKwon

@allisonwang-db allisonwang-db Awaiting requested review from allisonwang-db

Assignees
No one assigned
Labels
PYTHON SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benrobby @benhurdelhey