Fix unknown metadata in L2 aggregate worker #13543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Oct 14, 2025
Comment on lines
+296
to
+298
| if (metrics instanceof Meter) { | ||
| ((Meter) metrics).initMeta(model.getName(), model.getScopeId()); | ||
| } |
There was a problem hiding this comment.
I don't remember other OAL metrics having this in serialization. Could you explain more about this issue?
There was a problem hiding this comment.
#createNew should include initMeta logic already. I think the correct approach should be to use the correct serialization in RemoteServiceHandler, rather than here.
There was a problem hiding this comment.
Recommend making RemoteHandleWorker handleWorker to provide an instance creator, and support OAL(new Object) and MAL(createNew) ways to initialize the object correctly.
wu-sheng
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unknown metadata in L2 aggregate worker
CHANGESlog.L2 aggregate worker can't get metrics metadata because metadata is not serialized in grpc message, which will skip analysing of next workers(alarm, exporter) under oap cluster mode.