Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify plugin.dest.dir property #746

Merged
merged 1 commit into from
Jan 10, 2025
Merged

modify plugin.dest.dir property #746

merged 1 commit into from
Jan 10, 2025

Conversation

JoeCqupt
Copy link
Contributor

@JoeCqupt JoeCqupt commented Jan 9, 2025

use ${maven.multiModuleProjectDirectory} to locate plugins dir

<plugin.dest.dir>${maven.multiModuleProjectDirectory}/skywalking-agent/plugins</plugin.dest.dir>

replace previously defined properties

<sdk.plugin.related.dir />
<agent.package.dest.dir>${project.build.directory}${sdk.plugin.related.dir}/../../../../skywalking-agent
</agent.package.dest.dir>
<plugin.dest.dir>${agent.package.dest.dir}/plugins</plugin.dest.dir>

especially,we can avoid the annoying sdk.plugin.related.dir property

the same to bootstrap.plugin.dest.dir expired.plugin.dest.dir optional.plugin.dest.dir optional.reporter.plugins.dest.dir

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added the enhancement New feature or request label Jan 10, 2025
@wu-sheng wu-sheng added this to the 9.4.0 milestone Jan 10, 2025
@wu-sheng wu-sheng merged commit 31bf638 into apache:main Jan 10, 2025
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants