Add Undertow 2.1.7.final+ worker thread pool metrics. #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Undertow 2.1.7.final+ worker thread pool metrics.
CHANGES
log.I found undertow worker thread pool monitoring is not supported in skywalking-showcase songs service which use
spring-boot-starter-undertow:2.5.6
.However
spring-boot-starter-undertow:2.5.6
is in our java-agent test matrix.After research, I located the problem of
undertow undertow-worker-thread-pool-scenario
, it just change test version ofspring-boot-starter-undertow
,but forgot to upgrade the version of
spring-boot-dependencies
, which actualy control the version of xnio(the impl of undertow worker threadpool).So currently, undertow only tested and supported in xnio version 3.3.8.final. In showcase songs service, we use xnio 3.8.x.final, this explains why no threadpool metrics reported.
In this PR, I add 3.8.x as supported version and fix
undertow undertow-worker-thread-pool-scenario
to make sure it fully tested.