-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Kafka clients dependency version to 3.8.0 #731
Conversation
As discussed, I don't think updating this works. Have you tested with a Kafka cluster and OAP? |
Yes, I have already tested the Kafka client version 3.8.0 locally to connect to the Kafka cluster and report link data to OAP. Currently, the data reporting to OAP is normal. |
Let's see how the e2e says. |
If all are working, remember to update the change log accordingly. |
Maybe because of Kafka server version? Or something? |
Starting from Kafka Clients 3.0, acks It will lead to increasing latency. I suppose it is not necessary for telemetry cases. |
Maybe we could change that configuration? Can we? Personally, the issue is we can't stay in an old and not-releasing version, as suffering CVEs. |
I think we can keep the current configurations by setting default properites |
Could you please tell me what modifications I need to make in order to pass the test cases, and then I can merge my code into the main repository? |
Any update? we should make the tests passed, then we talk about default configurations. |
Sorry to bother you, I need some help. How can I run test cases locally? Are there any guide documents available? |
Which part? e2e? You could follow this, https://skywalking.apache.org/docs/skywalking-infra-e2e/latest/en/setup/run-e2e-tests/ |
Thanks, this is the guide document I needed. |
CHANGES
log.