Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kafka clients dependency version to 3.8.0 #731

Closed
wants to merge 5 commits into from

Conversation

Super-Lu
Copy link

@Super-Lu Super-Lu commented Nov 28, 2024

@wu-sheng
Copy link
Member

As discussed, I don't think updating this works. Have you tested with a Kafka cluster and OAP?

@Super-Lu
Copy link
Author

As discussed, I don't think updating this works. Have you tested with a Kafka cluster and OAP?

Yes, I have already tested the Kafka client version 3.8.0 locally to connect to the Kafka cluster and report link data to OAP. Currently, the data reporting to OAP is normal.

@wu-sheng
Copy link
Member

Let's see how the e2e says.

@wu-sheng wu-sheng added this to the 9.4.0 milestone Nov 28, 2024
@wu-sheng
Copy link
Member

If all are working, remember to update the change log accordingly.

@wu-sheng
Copy link
Member

image

The e2e reports failure. Please recheck this e2e.

@wu-sheng
Copy link
Member

Maybe because of Kafka server version? Or something?

@Super-Lu
Copy link
Author

Maybe because of Kafka server version? Or something?

image The e2e reports failure. Please recheck this e2e.

Okay, I'll check it out.

@lujiajing1126
Copy link
Contributor

Starting from Kafka Clients 3.0, acks
is changed from 1 to all, and idempotent is enabled by default.

It will lead to increasing latency. I suppose it is not necessary for telemetry cases.

@wu-sheng
Copy link
Member

Maybe we could change that configuration? Can we?

Personally, the issue is we can't stay in an old and not-releasing version, as suffering CVEs.

@lujiajing1126
Copy link
Contributor

Maybe we could change that configuration? Can we?

Personally, the issue is we can't stay in an old and not-releasing version, as suffering CVEs.

I think we can keep the current configurations by setting default properites

@Super-Lu
Copy link
Author

Super-Lu commented Dec 2, 2024

Maybe we could change that configuration? Can we?
Personally, the issue is we can't stay in an old and not-releasing version, as suffering CVEs.

I think we can keep the current configurations by setting default properites

Could you please tell me what modifications I need to make in order to pass the test cases, and then I can merge my code into the main repository?

@wu-sheng
Copy link
Member

wu-sheng commented Dec 4, 2024

Any update? we should make the tests passed, then we talk about default configurations.

@Super-Lu
Copy link
Author

Super-Lu commented Dec 5, 2024

Any update? we should make the tests passed, then we talk about default configurations.

Sorry to bother you, I need some help. How can I run test cases locally? Are there any guide documents available?

@wu-sheng
Copy link
Member

wu-sheng commented Dec 5, 2024

@Super-Lu
Copy link
Author

Super-Lu commented Dec 5, 2024

Which part? e2e? You could follow this, https://skywalking.apache.org/docs/skywalking-infra-e2e/latest/en/setup/run-e2e-tests/

Thanks, this is the guide document I needed.

@Super-Lu Super-Lu closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants