-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shade async-profiler packages #727
Conversation
Could you post the screenshot of new binary package here? And, have you tested the feature again? Shading sometimes breaks the function. |
About the so files, are they able to move as well? |
The .so file has not been moved yet. I think it should not be possible to move the .so file because the async-profiler code gets the dynamic library path based on the following code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a solution as long as you understand that shading in the agent package instead of agent-core will make it impossible to be used from other packages like plugins
Do you mean you prefer to move this(shade) into core module? I think plugins would not access this part of codes. |
I am OK with this one. |
@zhengziyi0117 Could you try that? |
9806c91
apm-sniffer/apm-agent-core/pom.xml
Outdated
@@ -226,6 +228,7 @@ | |||
<exclude>org.checkerframework:checker-compat-qual:jar:</exclude> | |||
<exclude>org.checkerframework:checker-qual:jar:</exclude> | |||
<exclude>org.codehaus.mojo:animal-sniffer-annotations:jar:</exclude> | |||
<!-- <exclude>tools.profiler:async-profiler:jar:</exclude>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should have this?
CHANGES
log.