Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CVE-2024-7254 #721

Closed
wants to merge 3 commits into from
Closed

fix CVE-2024-7254 #721

wants to merge 3 commits into from

Conversation

alanlvle
Copy link
Contributor

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added this to the 9.4.0 milestone Oct 10, 2024
@wu-sheng
Copy link
Member

I think somehow the compiling is broken by this. Could you try compiling locally and fix?

@wu-sheng
Copy link
Member

Maybe, you don't bump up protobuf-maven-plugin.version accordingly. They should be aligned.

@alanlvle
Copy link
Contributor Author

I try do it

@alanlvle
Copy link
Contributor Author

protobuf-maven-plugin.version is old.how to get new protobuf-maven-plugin version aligned to protobuf-java

@wu-sheng
Copy link
Member

protobuf-java should have documents mentioned that.

@lujiajing1126
Copy link
Contributor

I suppose grpc-java version should be compatible with the upgraded protobuf-java

@alanlvle
Copy link
Contributor Author

alanlvle commented Oct 11, 2024

com.google.protobuf:protobuf-java is only used in java-agent-network,so,only update com.google.protobuf:protobuf-java in java-agent-network

@wu-sheng
Copy link
Member

Why don't update the gRPC accordingly? I think taking the risk of incompatible grpc and protobuf version are not a good idea.

@alanlvle
Copy link
Contributor Author

io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5

@wu-sheng
Copy link
Member

I think we can wait. We don't have plans to release the next Java agent soon. Not much changed.

image

@alanlvle
Copy link
Contributor Author

OK

@lujiajing1126
Copy link
Contributor

lujiajing1126 commented Oct 11, 2024

io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5

https://repo1.maven.org/maven2/io/grpc/grpc-protobuf/1.68.0/grpc-protobuf-1.68.0.pom

grpc-protobuf 1.68.0 already uses protobuf-java 3.25.3. I think patch version bump will not break the compatibility.

See the comment here grpc/grpc-java#11542 (comment)

Also, the upstream PR grpc/grpc-java#11543 shows nothing change except version number.

@wu-sheng
Copy link
Member

No update. Please reopen when you are ready.

@wu-sheng wu-sheng closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants