-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CVE-2024-7254 #721
fix CVE-2024-7254 #721
Conversation
I think somehow the compiling is broken by this. Could you try compiling locally and fix? |
Maybe, you don't bump up |
I try do it |
protobuf-maven-plugin.version is old.how to get new protobuf-maven-plugin version aligned to protobuf-java |
protobuf-java should have documents mentioned that. |
I suppose grpc-java version should be compatible with the upgraded protobuf-java |
com.google.protobuf:protobuf-java is only used in java-agent-network,so,only update com.google.protobuf:protobuf-java in java-agent-network |
Why don't update the gRPC accordingly? I think taking the risk of incompatible grpc and protobuf version are not a good idea. |
io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5 |
OK |
https://repo1.maven.org/maven2/io/grpc/grpc-protobuf/1.68.0/grpc-protobuf-1.68.0.pom grpc-protobuf 1.68.0 already uses protobuf-java 3.25.3. I think patch version bump will not break the compatibility. See the comment here grpc/grpc-java#11542 (comment) Also, the upstream PR grpc/grpc-java#11543 shows nothing change except version number. |
No update. Please reopen when you are ready. |
CHANGES
log.