Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for httpasyncclient #714

Closed
wants to merge 1 commit into from

Conversation

lu-xiaoshuang
Copy link

@lu-xiaoshuang lu-xiaoshuang commented Aug 12, 2024

HttpHost info is missing in URL tag, if public <T> Future<T> execute(final HttpAsyncRequestProducer requestProducer, ... and/or public Future<HttpResponse> execute(final HttpHost target, final HttpRequest request, ... are/is used.

    closeableHttpAsyncClient.execute(
        HttpHost.create("http://address:port"),
        new HttpGet("/path"),
        new FutureCallbackImpl<HttpResponse>());

@wu-sheng
Copy link
Member

Could you update tesr scenario of http async client to add one call of using this way and add an expected span in the expected file?

@wu-sheng wu-sheng added bug Something isn't working plugin labels Aug 12, 2024
@wu-sheng
Copy link
Member

Also, changelogs should be updated too. You didn't follow the templ of pull request.

@wu-sheng
Copy link
Member

Please follow previous comments and fix CIs.

@wu-sheng
Copy link
Member

I think you didn't follow plugin dev doc.

We didn't trust UTs, as most data are mocked, which means nothing to the agent use. We built and run real application to verify.

@wu-sheng
Copy link
Member

Close as no update accordingly.

@wu-sheng wu-sheng closed this Aug 17, 2024
@wu-sheng wu-sheng added the stale label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants