Add mongoDB plugin report db instance info #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please format the PR, this seems no clear description. |
I have enriched the description information, please check the PR |
wu-sheng
reviewed
Oct 8, 2023
| @@ -43,6 +44,13 @@ public static void createExitSpan(String executeMethod, String remotePeer, Objec | |||
| Tags.DB_TYPE.set(span, MongoConstants.DB_TYPE); | |||
| SpanLayer.asDB(span); | |||
|
|
|||
| if (operation instanceof EnhancedInstance) { | |||
There was a problem hiding this comment.
What is the case not instanceof? Or this is just an extra check?
There was a problem hiding this comment.
For example,'CommitTransactionOperation' cannot obtain the corresponding database info
wu-sheng
reviewed
Oct 8, 2023
|
For others reading this PR, the context happens at #597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes apache/skywalking#11252.
Update the CHANGES log.