Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the data type of the clsTime field in the BrowserWebVitalsPerfData protobuf message from int32 to double. This change is necessary because Cumulative Layout Shift (CLS) is a floating-point score metric, not an integer time value.
Key changes:
- Changed
clsTimefield type fromint32todoublein theBrowserWebVitalsPerfDatamessage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
browser/BrowserPerf.proto
Outdated
| @@ -133,7 +133,7 @@ message BrowserWebVitalsPerfData { | |||
| // First Meaningful Paint time | |||
| int32 fmpTime = 5; | |||
| // Cumulative Layout Shift time | |||
There was a problem hiding this comment.
The comment "Cumulative Layout Shift time" is misleading. CLS (Cumulative Layout Shift) is not a time metric but a dimensionless score that measures visual stability. The comment should be updated to reflect this, for example: "Cumulative Layout Shift score" or "Cumulative Layout Shift value".
| // Cumulative Layout Shift time | |
| // Cumulative Layout Shift score |
relate to apache/skywalking#13596