-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4988] Fix swagger doc registered appName use contextPath #4989
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4989 +/- ##
============================================
- Coverage 60.99% 60.99% -0.01%
Complexity 8622 8622
============================================
Files 1258 1258
Lines 38426 38426
Branches 3679 3679
============================================
- Hits 23439 23438 -1
Misses 12871 12871
- Partials 2116 2117 +1 ☔ View full report in Codecov by Sentry. |
Is it because the prefix is added with "/"? Because the apidoc generated by Shenyu annotation also uses contextpath as appname (i.e. the tagName field of the tag table). If you want to modify it, it is recommended to also modify the apidoc generated by the shenyu annotation. Strictly speaking, the appname field has not been designed for the database table yet, and we plan to add it later. |
@lianjunwei I am willing to complete the remaining tasks : add |
@GOODBOY008 GOODBOY008Hi, The soonest, I will initiate a discussion next weekend, and I will notify you via email([email protected]) and WeChat contributor group in advance, and I will also remind you in the WeChat group. |
In fact, at present, the apidoc function cannot get the appName, so the contextpath is temporarily used as the appName, and this function may be added later. In addition, the database table should also add the appname field |
remove duplicated imports
add importing okhttp3.Response
Close #4988