Remove DatabaseMetaDataNodePath.getTableRootPath()

apache · Feb 5, 2025 · c810b34 · c810b34
1 parent 9948a73
commit c810b34
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 19 deletions.
diff --git a/...e/shardingsphere/mode/metadata/persist/metadata/service/SchemaMetaDataPersistService.java b/...e/shardingsphere/mode/metadata/persist/metadata/service/SchemaMetaDataPersistService.java
@@ -19,8 +19,9 @@
 
 import org.apache.shardingsphere.infra.metadata.database.schema.manager.GenericSchemaManager;
 import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
-import org.apache.shardingsphere.mode.node.path.metadata.DatabaseMetaDataNodePath;
 import org.apache.shardingsphere.mode.metadata.persist.version.MetaDataVersionPersistService;
+import org.apache.shardingsphere.mode.node.path.metadata.DatabaseMetaDataNodePath;
+import org.apache.shardingsphere.mode.node.path.metadata.TableMetaDataNodePath;
 import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
 
 import java.util.Collection;
@@ -51,7 +52,7 @@ public SchemaMetaDataPersistService(final PersistRepository repository, final Me
      * @param schemaName to be added schema name
      */
     public void add(final String databaseName, final String schemaName) {
-        repository.persist(DatabaseMetaDataNodePath.getTableRootPath(databaseName, schemaName), "");
+        repository.persist(TableMetaDataNodePath.getMetaDataTablesPath(databaseName, schemaName), "");
     }
 
     /**

diff --git a/...main/java/org/apache/shardingsphere/mode/node/path/metadata/DatabaseMetaDataNodePath.java b/...main/java/org/apache/shardingsphere/mode/node/path/metadata/DatabaseMetaDataNodePath.java
@@ -82,17 +82,6 @@ public static String getSchemaPath(final String databaseName, final String schem
         return String.join("/", getSchemaRootPath(databaseName), schemaName);
     }
 
-    /**
-     * Get table root path.
-     *
-     * @param databaseName database name
-     * @param schemaName schema name
-     * @return table root path
-     */
-    public static String getTableRootPath(final String databaseName, final String schemaName) {
-        return String.join("/", getSchemaPath(databaseName, schemaName), TABLES_NODE);
-    }
-
     /**
      * Get version path.
      *

diff --git a/...rc/main/java/org/apache/shardingsphere/mode/node/path/metadata/TableMetaDataNodePath.java b/...rc/main/java/org/apache/shardingsphere/mode/node/path/metadata/TableMetaDataNodePath.java
@@ -32,7 +32,7 @@ public final class TableMetaDataNodePath {
 
     private static final String ROOT_NODE = "/metadata";
 
-    private static final String SCHEMAS_NODE = "schemas";
+    private static final String SCHEMAS_NODE = "schemas";e
 
     private static final String TABLES_NODE = "tables";
 

diff --git a/.../src/test/java/org/apache/shardingsphere/mode/node/path/DatabaseMetaDataNodePathTest.java b/.../src/test/java/org/apache/shardingsphere/mode/node/path/DatabaseMetaDataNodePathTest.java
@@ -50,11 +50,6 @@ void assertGetSchemaPath() {
         assertThat(DatabaseMetaDataNodePath.getSchemaPath("foo_db", "foo_schema"), is("/metadata/foo_db/schemas/foo_schema"));
     }
 
-    @Test
-    void assertGetTableRootPath() {
-        assertThat(DatabaseMetaDataNodePath.getTableRootPath("foo_db", "foo_schema"), is("/metadata/foo_db/schemas/foo_schema/tables"));
-    }
-
     @Test
     void assertGetVersionPath() {
         assertThat(DatabaseMetaDataNodePath.getVersionPath("foo_rule", "1"), is("foo_rule/1"));