-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Zeta] Introduce SeaTunnel CompletableFuture to prevent ForkJoinPool thread shortage #8445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
SeaTunnel core module
flink
Zeta
connectors-v2
e2e
api
labels
Jan 3, 2025
hailin0
reviewed
Jan 3, 2025
@Override | ||
public Thread newThread(Runnable r) { | ||
return new Thread( | ||
r, "CompletableFuture-Thread-" + seq.getAndIncrement()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
r, "CompletableFuture-Thread-" + seq.getAndIncrement()); | |
r, "SeaTunnel-CompletableFuture-Thread-" + seq.getAndIncrement()); |
Hisoka-X
force-pushed
the
new-completablefuture
branch
from
January 6, 2025 11:14
76eb866
to
1f53c00
Compare
Hisoka-X
force-pushed
the
new-completablefuture
branch
from
January 6, 2025 12:55
578b3ed
to
501a423
Compare
Hisoka-X
force-pushed
the
new-completablefuture
branch
from
January 7, 2025 03:28
501a423
to
698a4af
Compare
Hisoka-X
changed the title
[Fix][Core] Introduce SeaTunnel CompletableFuture to prevent ForkJoinPool thread shortage
[Fix][Zeta] Introduce SeaTunnel CompletableFuture to prevent ForkJoinPool thread shortage
Jan 7, 2025
hailin0
approved these changes
Jan 7, 2025
dailai
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wuchunfu
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
In Zeta, we extensively use Java's CompletableFuture object, and there are cases where CompletableFuture tasks are nested. The default ForkJoinPool thread pool is insufficient under heavy load. To address this, we introduced our own CompletableFuture in Zeta, leveraging a cached thread pool for task execution. Additionally, we modified Hazelcast's internal InvocationFuture to use the same thread pool.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note
.