added primitive match return function to CDMS reader #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngachung
requested changes
Jul 7, 2023
tools/cdms/cdms_reader.py
Outdated
| sec_lat.append(float(secondary.lat[int(y)].values)) | ||
| sec_time.append(float(secondary.time[int(y)].values)) | ||
| sec_speed.append(float(secondary.wind_speed[int(y)].values)) | ||
| sec_dir.append(float(secondary.wind_to_direction[int(y)].values)) |
There was a problem hiding this comment.
@alovett-COAPS This change to the reader appears to be specific just for the primary = sst and secondary = wind use case. This reader should be generic to support any variable(s). In the use case where secondary is an in situ source there can be also be multiple variables returned.
alovett-COAPS
commented
Oct 18, 2023
ngachung
reviewed
Nov 16, 2023
tools/cdms/README.md
Outdated
| @@ -14,7 +14,7 @@ Imported packages: | |||
| * csv | |||
| * collections | |||
| * logging | |||
| * xarray | |||
There was a problem hiding this comment.
@alovett-COAPS It appears xarray isn't used at all in cdms_reader.py so I think we should remove it as a dependency.
ngachung
previously approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfils requirement from SDAP-470- adding in functionality to cdms_reader.py to return matches in an alternate, simplified format