SDAP-367: Updated deletebyquery tool to improve speed #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankinspace
reviewed
Mar 9, 2022
|
|
||
| doc_ids.extend([uuid.UUID(doc['id']) for doc in solr_response.result.response.docs]) | ||
| ids = [uuid.UUID(doc['id']) for doc in solr_response.result.response.docs] | ||
| delete_from_cassandra(ids) |
There was a problem hiding this comment.
you moved the cassandra delete into the do_solr_query function? This seems like it would break things. do_solr_query is collecting all of the tile ids that need to be deleted. Once that is done it asks the user to confirm the number of documents before executing the delete. With this new flow, the cassandra rows get removed before the solr docs and a user could decide to cancel without realizing data has already been deleted.
There was a problem hiding this comment.
@frankinspace Whoops, good point. I'll refactor this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fand--forceflag that will skip the prompts before deleting