SAMZA-2642: Set a default character set in InputStreamReader to solve… #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… potential garbled problems
|
Can you please update the description following the guideline? |
|
@mynameborat Thanks for the reminder! The description has been added now. |
Thank you! It will be useful to describe the scenario where this is problematic and provide some context on the background of the issue. The description right now talks about solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… potential garbled problems
Issues: When a InputStreamReader is used, the parameter setting of a default character set is recommended to solve potential garbled problems.
Changes: Set a default character set in InputStreamReader API.
Tests: No tests. TODO.