[ISSUE #10969] Hoist per-batch constant min/max offset strings out of message loop in PullAPIWrapper

[wang-jiahua]

Which Issue(s) This PR Fixes

Fixes #10969

Brief Description

In PullAPIWrapper#processPullResult, the per-message loop calls Long.toString(pullResult.getMinOffset()) and Long.toString(pullResult.getMaxOffset()) for every message, although both values are constant within one pull response. A 32-message batch allocates 64 identical short-lived strings where 2 suffice, on every pull response of every push/pull consumer.

This PR hoists the two Long.toString calls out of the loop and reuses the two strings for the whole batch. No behavior change: property values are identical and putProperty semantics are untouched.

How Did You Test This Change?

• PullAPIWrapperTest passes (11/11).
• Joint A/B benchmark on a 4-node cluster (producer 64 threads + consumer 20 threads, 1 KiB body; only the consumer-side client jar swapped per arm; 3 interleaved 60 s trials): consumer young GC per million consumed messages 1.10/1.06/1.17 (base) vs 1.08/1.06/1.07 (patch), consume TPS flat — no regression. The saving itself is tens of short-lived strings per batch, below GC-count resolution; this is a cleanup-level optimization on a hot path.

[Copilot]

Pull request overview

This PR optimizes PullAPIWrapper#processPullResult by reducing per-message allocations when annotating pulled messages with batch-level min/max offsets, aligning with the hot-path allocation reduction described in Issue #10969.

Changes:

• Hoists Long.toString(pullResult.getMinOffset()/getMaxOffset()) out of the per-message loop.
• Reuses the resulting minOffset/maxOffset strings for all messages in the pull batch.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[RockteMQ-AI]

LGTM. Clean optimization — hoisting the two Long.toString() calls out of the per-message loop is correct since pullResult.getMinOffset() and pullResult.getMaxOffset() are constant within a single pull response. Reduces unnecessary short-lived string allocations on a hot path with zero behavior change.

---

Automated review by github-manager-bot

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.50%. Comparing base (e348efa) to head (851b437).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10971      +/-   ##
=============================================
- Coverage      48.56%   48.50%   -0.07%     
+ Complexity     13672    13650      -22     
=============================================
  Files           1381     1381              
  Lines         101475   101475              
  Branches       13190    13190              
=============================================
- Hits           49286    49216      -70     
- Misses         46185    46245      +60     
- Partials        6004     6014      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.