[ISSUE #10383] Fix flaky store and proxy tests#10407
Open
RongtongJin wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10407 +/- ##
=============================================
- Coverage 49.01% 47.92% -1.09%
+ Complexity 13485 13249 -236
=============================================
Files 1376 1376
Lines 100527 100536 +9
Branches 12983 12983
=============================================
- Hits 49274 48184 -1090
- Misses 45251 46410 +1159
+ Partials 6002 5942 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up for the tests called out around #10404 and the broader #10383 test stability/dependency work. It keeps the tests enabled and makes the repeated-run behavior deterministic instead of quarantining them.
AutoSwitchHATestand pass the actual bound HA address after startup.AutoSwitchHATestteardown paths to prevent repeated-run file lock noise.localhost:0for single-node tests, available ephemeral ports for two-node tests) instead of the sharednextPort()sequence.ReceiptHandleProcessorTestdeterministic by setting the mocked channel online before the renewal scheduler starts, returning a completed renewal future, and shutting down the processor in teardown.Validation
AutoSwitchHATest#testAddBrokerfailure with127.0.0.1:10912pre-bound; it failed before the change and passed after the dynamic-port fix.mvn -q -pl store -am -DskipITs -DfailIfNoTests=false -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=AutoSwitchHATest#testConfirmOffset testpassed 3 consecutive runs.mvn -q -pl store -am -DskipITs -DfailIfNoTests=false -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=AutoSwitchHATest,DLedgerCommitlogTest,DLedgerMultiPathTest testpassed 100 total runs; each run reportedTests run: 12, Failures: 0, Errors: 0, Skipped: 3on this macOS environment, with noConditionTimeoutException,BindException,release file lock error,ClassNotFoundException, or forked VM failure in the accepted logs.mvn -q -pl store -am -DskipITs -DfailIfNoTests=false -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=DLedgerCommitlogTest,DLedgerMultiPathTest testpassed on this macOS environment with the existing platform assumptions (Tests run: 2, Failures: 0, Errors: 0, Skipped: 2).mvn -q -pl proxy -am -DskipITs -DfailIfNoTests=false -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=ReceiptHandleProcessorTest testpassed 100 consecutive independent Maven runs, with noArgument(s) are different,NullPointerException, or Mockito strict stubbing error in the logs.mvn -q -pl store -am -DskipITs -Dcheckstyle.skip=true -Dspotbugs.skip=true test-compilepassed.Bazel validation was not run locally because
bazelis not installed in this environment (zsh: command not found: bazel).