Skip to content

[ISSUE #10400] Cache Version.values() in MQVersion to avoid repeated array allocation #10401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qianye1001 wants to merge 2 commits into
base: develop
Choose a base branch
from
+10 −8
Open

[ISSUE #10400] Cache Version.values() in MQVersion to avoid repeated array allocation #10401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129fd2e
fix: cache Version.values() in MQVersion to avoid repeated array allo…
web-flow May 28, 2026
5dd98cc
ci: trigger CI rerun for flaky integration tests
qianye1001 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions common/src/main/java/org/apache/rocketmq/common/MQVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,24 @@ public class MQVersion {

public static final int CURRENT_VERSION = Version.V5_5_0.ordinal();

private static final Version[] VERSION_VALUES = Version.values();

public static String getVersionDesc(int value) {
int length = Version.values().length;
Version[] versions = VERSION_VALUES;
int length = versions.length;
if (value >= length) {
return Version.values()[length - 1].name();
return versions[length - 1].name();
}

return Version.values()[value].name();
return versions[value].name();
}

public static Version value2Version(int value) {
int length = Version.values().length;
Version[] versions = VERSION_VALUES;
int length = versions.length;
if (value >= length) {
return Version.values()[length - 1];
return versions[length - 1];
}

return Version.values()[value];
return versions[value];
}

public enum Version {
Expand Down
Loading