Skip to content

Conversation

@contrueCT
Copy link

@contrueCT contrueCT commented Oct 23, 2025

What is the purpose of the change

When a listener class annotated with @RocketMQMessageListener is also proxied (e.g., by @RefreshScope), the annotation may not be detected in BeanPostProcessor, causing the consumer not to register.
https://github.com/apache/rocketmq/issues/9564

Brief changelog

  • v4: Use AopProxyUtils.ultimateTargetClass + AnnotationUtils.findAnnotation in RocketMQMessageListenerBeanPostProcessor to robustly detect annotations on proxied beans.
  • v4: Emit WARN (RocketMQUtil style) only for likely listener beans (implement RocketMQListener/RocketMQReplyListener or having onMessage method) when proxied/scoped/@RefreshScope is present, guiding users not to put @RefreshScope on listener classes.
  • v5: Apply the same enhancements in the v5 RocketMQMessageListenerBeanPostProcessor.
  • tests(v4): Add a scoped-proxy listener test in RocketMQMessageListenerBeanPostProcessorTest to ensure registration path is executed for proxied listeners.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…e; add v4 test

- v4: Use AopProxyUtils.ultimateTargetClass + AnnotationUtils.findAnnotation in
  RocketMQMessageListenerBeanPostProcessor to robustly detect annotations on proxied beans.
  Log WARN (RocketMQUtil style) only for likely listener beans (implement RocketMQListener/
  RocketMQReplyListener or have onMessage method) when proxied/scoped/@RefreshScope is present.
- v5: Apply the same enhancements to the v5 RocketMQMessageListenerBeanPostProcessor.
- tests(v4): Add a scoped-proxy listener test in RocketMQMessageListenerBeanPostProcessorTest
  to ensure registration path is executed for proxied listeners.

Refs: apache/rocketmq#9564
@contrueCT
Copy link
Author

@RongtongJin Hello, can you take a look for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant