RANGER-5061: Fix for Admin audit page loading failure #514
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib7241c3d2673a358c3753cb035e9a14a6e6be5a4
vyommani
reviewed
Jan 21, 2025
There was a problem hiding this comment.
I've reviewed the changes, and while they look okay, I have concerns about the relation to RANGER-5061. The changes in RANGER-5061 seem to be mostly code readability improvements (primarily formatting) and shouldn't alter the code's logic.
mneethiraj
approved these changes
Jan 21, 2025
@vyommani - good point. This regression is caused by one of my commits - 4a0e5bb#diff-cc35b70f378515ceb3c6393826e71032a9d795d3d2623acae413790a6ce6cb54R477. I will review further for such issues shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib7241c3d2673a358c3753cb035e9a14a6e6be5a4
What changes were proposed in this pull request?
Previous commits of RANGER-5061 caused Admin audit page loading failure. This request shall handle the NullPointerException.
How was this patch tested?
Installed ranger admin with this page and checked that Admin audit page is loading properly.