fix: remove usage of tty to avoid introducing \r#661
Merged
visortelle merged 1 commit intoapache:masterfrom Mar 7, 2026
Merged
fix: remove usage of tty to avoid introducing \r#661visortelle merged 1 commit intoapache:masterfrom
visortelle merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Fixes #660 |
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #660 by preventing carriage return (\r) characters from being introduced into generated JWT tokens during Helm release preparation.
Changes:
- Remove TTY allocation (
-t) fromdocker runinvocations used to generate symmetric and asymmetric JWT tokens.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@soyji thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Motivation
Fix #660
Modifications
Describe the modifications you've done.
Verifying this change