Docs: Fix the wrong catalog name in using polaris page

[owenowenisme]

The SQL command in the "using polaris" page is using the wrong catalog name, it should be quickstart_catalog instead of polaris according to the quick start instruction.

[adnanhemani]

Don’t think this is correct, check this:

polaris/getting-started/eclipselink/docker-compose.yml

Line 78 in 1fb194e

--conf, "spark.sql.catalog.polaris=org.apache.iceberg.spark.SparkCatalog",

Can look further into this tomorrow, but in the meantime, please reverify and paste your output that shows this being correctly run without any changes.

[owenowenisme]

@adnanhemani Thanks for commenting!
When I follow this

polaris/site/content/in-dev/unreleased/getting-started/using-polaris.md

Lines 32 to 40 in 1fb194e

	./polaris \
	--client-id ${CLIENT_ID} \
	--client-secret ${CLIENT_SECRET} \
	catalogs \
	create \
	--storage-type s3 \
	--default-base-location ${DEFAULT_BASE_LOCATION} \
	--role-arn ${ROLE_ARN} \
	quickstart_catalog

The instruction tell us to define a catalog named quickstart_catalog ,
so I think that the Sample Command section

polaris/site/content/in-dev/unreleased/getting-started/using-polaris.md

Lines 187 to 197 in 1fb194e

	#### Sample Commands
	Once the Spark session starts, we can create a namespace and table within the catalog:
	```sql
	USE polaris;
	CREATE NAMESPACE IF NOT EXISTS quickstart_namespace;
	CREATE NAMESPACE IF NOT EXISTS quickstart_namespace.schema;
	USE NAMESPACE quickstart_namespace.schema;
	CREATE TABLE IF NOT EXISTS quickstart_table (id BIGINT, data STRING) USING ICEBERG;
	```

should also be quickstart_catalog or it will be misleading.

[adnanhemani]

There’s a difference between a Spark Catalog and a Polaris Catalog. It makes sense that it can be confusing, so maybe we add a line in the documentation that states that we have added a Spark catalog named “polaris” that points to the “quickstart_catalog” - or change all references in the Spark configs to “quickstart_catalog”. What are your thoughts?

cc @adutra, who I believe was the original author of the Dockerfiles where this was named.

[owenowenisme]

My thought is to change all references in the Spark configs to “quickstart_catalog” since 0.9.0 doc also do it this way.

polaris/site/content/in-dev/0.9.0/quickstart.md

Lines 284 to 297 in 1fb194e

	Once the Spark session starts, we can create a namespace and table within the catalog:
	```
	spark.sql("USE quickstart_catalog")
	spark.sql("CREATE NAMESPACE IF NOT EXISTS quickstart_namespace")
	spark.sql("CREATE NAMESPACE IF NOT EXISTS quickstart_namespace.schema")
	spark.sql("USE NAMESPACE quickstart_namespace.schema")
	spark.sql("""
	CREATE TABLE IF NOT EXISTS quickstart_table (
	id BIGINT, data STRING
	)
	USING ICEBERG
	""")
	```

[eric-maynard]

Looking at the invocation, quickstart_catalog looks correct cc @adnanhemani

bin/spark-sql \
--packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.7.1,org.apache.hadoop:hadoop-aws:3.4.0 \
--conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
--conf spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog \
. . .

[adnanhemani]

@eric-maynard - yes, that invocation is only for the local Spark setup, however (which from personal experience is very hit or miss on whether folks can set it up or not). For the Docker Spark instructions, the catalog is called polaris (as per

polaris/getting-started/eclipselink/docker-compose.yml

Line 78 in 1fb194e

--conf, "spark.sql.catalog.polaris=org.apache.iceberg.spark.SparkCatalog",

). This is an issue - both should've been mirrors of each other.

@owenowenisme - I agree with your recommendation. Can you please change the Docker Compose files as well to mirror this quickstart_catalog Spark catalog name? If possible, let's hold on merging this until we get those changes as well. If not, I can branch a new PR to make those changes too.

[owenowenisme]

@adnanhemani I changed them all in this PR, PTAL.
And thanks for reviewing!

[adnanhemani]

LGTM, thank you for this @owenowenisme!!

[eric-maynard]

Not relevant to this PR, but I still find this line really scary. This seems like a recipe for someone unknowingly pushing their credentials to GH.

[owenowenisme]

I think you're right!
I can open another PR to use env variable instead.
WDYT?

[adnanhemani]

If you can make it work, then yes please!

[owenowenisme]

I'll start as soon as this PR is merged.