JDBC: create objects without reflection #1434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
requested review from
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
dimas-b
reviewed
Apr 23, 2025
| (Converter<T>) | ||
| entityClass.getDeclaredConstructor().newInstance(); // Create a new instance | ||
| R entity = transformer.apply(object.fromResultSet(resultSet)); | ||
| Converter<T> model = (Converter<T>) createModelInstance(entityClass); |
There was a problem hiding this comment.
How about changing entityClass to Function<ResultSet, R> converter and removing transformer.
Then:
public static ModelEntity fromResultSet(ResultSet r) {
return ModelEntity.builder()
....
End result: no reflection, not if/else, one less method param, simpler entity classes.
There was a problem hiding this comment.
+1. It's a good idea to combine toEntity() and fromResultSet() here.
|
In #1487 I solved this by just having the caller pass in an instance of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create model objects without reflection :
Address feedback here
cc @flyrain @eric-maynard