Add optional format parameter to loadGenericTable
#1432
Conversation
eric-maynard
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
jackye1995,
jbonofre and
vvcephei
as code owners
eric-maynard
requested review from
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
| @@ -116,7 +116,15 @@ paths: | |||
| Load a generic table from the catalog under the given namespace. | |||
|
|
|||
| The response contains all table information passed during create. | |||
|
|
|||
| parameters: | |||
| - name: format | |||
There was a problem hiding this comment.
when i look at Rahil's design, i think he is proposing to add a new key target-metadata-path in the loadGenericTable response
There was a problem hiding this comment.
This is for the request, not the response.
There was a problem hiding this comment.
Yes, in this doc, i don't see he is proposing to add new fields to the load API, I though he is just going to include this field in the response for all tables with other read format enabled
There was a problem hiding this comment.
To be clear I am proposing this -- but we'll do an ML thread to hash out the details. There is a bit of discussion here on Rahil's draft PR that I think you're referring to, but that's not merged yet. Sorry for any confusion
There was a problem hiding this comment.
sorry, I am not referring to the pr, what i
mean is the doc here https://docs.google.com/document/d/1SfQXPOc0EtgESEBQPtgn2nTr1lyscxg4t-HskjUSPgI/edit?tab=t.0#heading=h.f583w6js2dar. Maybe we should go through the design first to make sure we are all aligned on the API changes.
To support table conversion on read, a small spec change is needed to the loadGenericTable endpoint. This will allow the client to optionally request conversion to a specified format, and if specified it could allow the catalog to reject the request when conversion is not possible.