Implement specificWorkbookSheet method #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Jul 9, 2021
| @@ -668,7 +668,7 @@ protected void processSheetHeader(Element htmlBody, HSSFSheet sheet) { | |||
| htmlBody.appendChild(h2); | |||
| } | |||
|
|
|||
| public void processWorkbook(HSSFWorkbook workbook) { | |||
| public void processWorkbookSheet(HSSFWorkbook workbook) { | |||
There was a problem hiding this comment.
This doesn't need to be renamed
There was a problem hiding this comment.
Yes, naming is not an issue. It was just my idea. Keeping the name same is also fine
pjfanning
reviewed
Jul 9, 2021
| @@ -692,6 +692,24 @@ public void processWorkbook(HSSFWorkbook workbook) { | |||
| htmlDocumentFacade.updateStylesheet(); | |||
| } | |||
|
|
|||
| public void processWorkbookSheet(HSSFWorkbook workbook, int sheetNumber) { | |||
There was a problem hiding this comment.
Can you call this processWorksheet?
There was a problem hiding this comment.
would it be better to just pass a HSSFWorksheet in the input instead of a workbook and sheetNumber?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specificWorkbookSheet() takes a workbook and sheetNumber as an argument, and creates an html of a specific sheet using the predefined method processSheet().
Initially it was not possible as processSheet() is protected and cannot be used.