Skip to content

Commit

Permalink
Assert that deleting test-files and entries works in tests
Browse files Browse the repository at this point in the history
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912709 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
centic9 committed Oct 3, 2023
1 parent a5b4a35 commit e8e6f67
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
package org.apache.poi.xssf.streaming;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.Row;
Expand Down Expand Up @@ -62,7 +63,7 @@ void testWriteUnicodeSurrogates() throws IOException {
assertEquals(unicodeText, cell2.getStringCellValue());
}
} finally {
tf.delete();
assertTrue(tf.delete());
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
package org.apache.poi.xssf.usermodel;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.Row;
Expand Down Expand Up @@ -61,7 +62,7 @@ void testWriteUnicodeSurrogates() throws IOException {
assertEquals(unicodeText, cell2.getStringCellValue());
}
} finally {
tf.delete();
assertTrue(tf.delete());
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ void readFromZipStream() throws IOException {
}
assertEquals(2, count);
} finally {
tempFile.delete();
assertTrue(tempFile.delete());
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.io.ByteArrayInputStream;
import java.io.IOException;
Expand Down Expand Up @@ -89,7 +90,7 @@ private void setTitle(POIFSFileSystem fs) throws NoPropertySetStreamException, I

summary1.setTitle(title);
//write the modified property back to POIFS
fs.getRoot().getEntryCaseInsensitive(SummaryInformation.DEFAULT_STREAM_NAME).delete();
assertTrue(fs.getRoot().getEntryCaseInsensitive(SummaryInformation.DEFAULT_STREAM_NAME).delete());
fs.createDocument(summary1.toInputStream(), SummaryInformation.DEFAULT_STREAM_NAME);

// check that the information was added successfully to the filesystem object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@ void readWriteRead(String file, Function<String,POIFSFileSystem> opener) throws
main4096[4095] = -11;
testDir.createDocument("Normal4096", new ByteArrayInputStream(main4096));

root.getEntryCaseInsensitive("Tags").delete();
assertTrue(root.getEntryCaseInsensitive("Tags").delete());


// Write out, re-load
Expand Down Expand Up @@ -1848,7 +1848,7 @@ void readWriteRead(String file, Function<String,POIFSFileSystem> opener) throws


// Delete a directory, and add one more
testDir.getEntryCaseInsensitive("Testing 456").delete();
assertTrue(testDir.getEntryCaseInsensitive("Testing 456").delete());
testDir.createDirectory("Testing ABC");


Expand Down Expand Up @@ -1903,7 +1903,7 @@ void readWriteRead(String file, Function<String,POIFSFileSystem> opener) throws


// Delete a mini stream, add one more
testDir.getEntryCaseInsensitive("Mini").delete();
assertTrue(testDir.getEntryCaseInsensitive("Mini").delete());

byte[] mini3 = new byte[]{42, 0, 42, 0, 42, 0, 42};
testDir.createDocument("Mini3", new ByteArrayInputStream(mini3));
Expand Down Expand Up @@ -2179,8 +2179,8 @@ void createWriteRead() throws IOException {


// Delete a couple of streams
miniDoc.delete();
normDoc.delete();
assertTrue(miniDoc.delete());
assertTrue(normDoc.delete());


// Check - will have un-used sectors now
Expand Down

0 comments on commit e8e6f67

Please sign in to comment.