Skip to content

Commit

Permalink
Reduce flakiness of one test which compares two documents
Browse files Browse the repository at this point in the history
There are more places where a timestamp is stored in the zip-file, 
let's try to replace some more bytes to make comparison succeed
more often.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912126 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
centic9 committed Sep 6, 2023
1 parent 4b03c24 commit 04ae3b4
Showing 1 changed file with 35 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1840,6 +1840,41 @@ private byte[] removeTimestamp(byte[] bytes) {
bytes[11] = 0;
bytes[12] = 0;
bytes[13] = 0;

// there is a timestamp for every entry, so try to replace a few more byte-positions
// to reduce flakiness of this test, however we likely do not yet cover all entries
bytes[390] = 0;
bytes[391] = 0;
bytes[674] = 0;
bytes[883] = 0;
bytes[1207] = 0;
bytes[1208] = 0;
bytes[1433] = 0;
bytes[1434] = 0;
bytes[1817] = 0;
bytes[1818] = 0;
bytes[2098] = 0;
bytes[2099] = 0;
bytes[2762] = 0;
bytes[2763] = 0;
bytes[2382] = 0;
bytes[2383] = 0;
bytes[2827] = 0;
bytes[2828] = 0;
bytes[2884] = 0;
bytes[2885] = 0;
bytes[2946] = 0;
bytes[2947] = 0;
bytes[3009] = 0;
bytes[3010] = 0;
bytes[3075] = 0;
bytes[3076] = 0;
bytes[3134] = 0;
bytes[3135] = 0;
bytes[3195] = 0;
bytes[3196] = 0;
bytes[3267] = 0;
bytes[3268] = 0;
}

return bytes;
Expand Down

0 comments on commit 04ae3b4

Please sign in to comment.