Star-tree Index Builder: Support dimension columns with raw forward index + shared dictionary#18637
Open
deepthi912 wants to merge 1 commit into
Open
Conversation
… shared dictionary Thread IndexLoadingConfig through MultipleTreesBuilder and SegmentPreProcessor so the segment loader has the table's TableConfig available when the forward index is backed by external storage. Add a raw-FI + separate-dictionary fast path in PinotSegmentColumnReader.getDictId so the star-tree builder can resolve dictionary IDs for such columns. Propagate segment-level custom metadata to remote index buffers so downstream readers can locate their data source. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
deepthi912
added
star-tree index
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18637 +/- ##
============================================
- Coverage 56.82% 56.79% -0.04%
- Complexity 1 7 +6
============================================
Files 2571 2576 +5
Lines 149210 149501 +291
Branches 24109 24154 +45
============================================
+ Hits 84789 84907 +118
- Misses 57249 57410 +161
- Partials 7172 7184 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, we don't have a way to support StarTree index when the forward index is RAW, this PR adds in that support when the dictionary is separated out.
It also downstreams some properties needed for this to happen