Return false from HadoopPinotFS.isDirectory for missing paths#18626
Open
wolfkill wants to merge 1 commit into
Open
Return false from HadoopPinotFS.isDirectory for missing paths#18626wolfkill wants to merge 1 commit into
wolfkill wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18626 +/- ##
============================================
+ Coverage 64.40% 64.41% +0.01%
Complexity 1137 1137
============================================
Files 3337 3337
Lines 206069 206069
Branches 32128 32128
============================================
+ Hits 132710 132733 +23
+ Misses 62726 62700 -26
- Partials 10633 10636 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falsefromHadoopPinotFS.isDirectory()when the target path does not existRationale
HadoopPinotFS.isDirectory()usedFileSystem#getFileStatus()directly, so missing paths raisedFileNotFoundException. Other filesystem implementations such asLocalPinotFStreat missing paths as not directories. This makes the Hadoop implementation consistent for callers that useisDirectory()as a predicate.Addresses #7083.
Test Plan
./mvnw -pl pinot-plugins/pinot-file-system/pinot-hdfs -am -Dtest=HadoopPinotFSTest#testIsDirectoryReturnsFalseForNonExistentPath -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl pinot-plugins/pinot-file-system/pinot-hdfs -am -Dtest=HadoopPinotFSTest -Dsurefire.failIfNoSpecifiedTests=false test