-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add merge-only reducer API for intercepting intermediate results #18621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
navina
wants to merge
3
commits into
apache:master
Choose a base branch
from
navina:merge-only-reducer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilderUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pinot.core.common.datatable; | ||
|
|
||
| import it.unimi.dsi.fastutil.doubles.DoubleArrayList; | ||
| import it.unimi.dsi.fastutil.floats.FloatArrayList; | ||
| import it.unimi.dsi.fastutil.ints.IntArrayList; | ||
| import it.unimi.dsi.fastutil.longs.LongArrayList; | ||
| import it.unimi.dsi.fastutil.objects.ObjectArrayList; | ||
| import java.io.IOException; | ||
| import java.math.BigDecimal; | ||
| import org.apache.pinot.common.utils.ArrayListUtils; | ||
| import org.apache.pinot.common.utils.DataSchema.ColumnDataType; | ||
| import org.apache.pinot.spi.utils.ByteArray; | ||
|
|
||
|
|
||
| /** | ||
| * Helpers for writing values into a {@link DataTableBuilder}. | ||
| */ | ||
| public class DataTableBuilderUtils { | ||
| private DataTableBuilderUtils() { | ||
| } | ||
|
|
||
| /** | ||
| * Writes a non-null value of the given stored column data type into the {@link DataTableBuilder} at | ||
| * the given column. Supports all scalar and array stored types. OBJECT columns are NOT handled here | ||
| * (callers serialize them via the owning aggregation function). Used by the group-by result | ||
| * serialization on both the server ({@code GroupByResultsBlock}) and the merge-only reduce path. | ||
| */ | ||
| public static void setColumn(DataTableBuilder dataTableBuilder, ColumnDataType storedColumnDataType, | ||
| int columnIndex, Object value) | ||
| throws IOException { | ||
| switch (storedColumnDataType) { | ||
| case INT: | ||
| dataTableBuilder.setColumn(columnIndex, (int) value); | ||
| break; | ||
| case LONG: | ||
| dataTableBuilder.setColumn(columnIndex, (long) value); | ||
| break; | ||
| case FLOAT: | ||
| dataTableBuilder.setColumn(columnIndex, (float) value); | ||
| break; | ||
| case DOUBLE: | ||
| dataTableBuilder.setColumn(columnIndex, (double) value); | ||
| break; | ||
| case BIG_DECIMAL: | ||
| dataTableBuilder.setColumn(columnIndex, (BigDecimal) value); | ||
| break; | ||
| case STRING: | ||
| dataTableBuilder.setColumn(columnIndex, value.toString()); | ||
| break; | ||
| case BYTES: | ||
| dataTableBuilder.setColumn(columnIndex, (ByteArray) value); | ||
| break; | ||
| case INT_ARRAY: | ||
| if (value instanceof IntArrayList) { | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toIntArray((IntArrayList) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (int[]) value); | ||
| } | ||
| break; | ||
| case LONG_ARRAY: | ||
| if (value instanceof LongArrayList) { | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toLongArray((LongArrayList) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (long[]) value); | ||
| } | ||
| break; | ||
| case FLOAT_ARRAY: | ||
| if (value instanceof FloatArrayList) { | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toFloatArray((FloatArrayList) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (float[]) value); | ||
| } | ||
| break; | ||
| case DOUBLE_ARRAY: | ||
| if (value instanceof DoubleArrayList) { | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toDoubleArray((DoubleArrayList) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (double[]) value); | ||
| } | ||
| break; | ||
| case BIG_DECIMAL_ARRAY: | ||
| if (value instanceof ObjectArrayList) { | ||
| //noinspection unchecked | ||
| dataTableBuilder.setColumn(columnIndex, | ||
| ArrayListUtils.toBigDecimalArray((ObjectArrayList<BigDecimal>) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (BigDecimal[]) value); | ||
| } | ||
| break; | ||
| case STRING_ARRAY: | ||
| if (value instanceof ObjectArrayList) { | ||
| //noinspection unchecked | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toStringArray((ObjectArrayList<String>) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (String[]) value); | ||
| } | ||
| break; | ||
| case BYTES_ARRAY: | ||
| if (value instanceof ObjectArrayList) { | ||
| //noinspection unchecked | ||
| dataTableBuilder.setColumn(columnIndex, ArrayListUtils.toBytesArray((ObjectArrayList<ByteArray>) value)); | ||
| } else { | ||
| dataTableBuilder.setColumn(columnIndex, (ByteArray[]) value); | ||
| } | ||
| break; | ||
| default: | ||
| throw new IllegalStateException("Unsupported stored type: " + storedColumnDataType); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit odd, aren't all the intermediate results partial? Should it be something like
INCOMPLETE_MERGEinstead?