Fix Zookeeper browser handling for missing nodes#18610
Draft
wolfkill wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18610 +/- ##
=========================================
Coverage 64.37% 64.37%
Complexity 1137 1137
=========================================
Files 3335 3335
Lines 206065 206065
Branches 32136 32136
=========================================
+ Hits 132649 132653 +4
+ Misses 62760 62759 -1
+ Partials 10656 10653 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9987.
When a selected znode disappears before the browser expands it, the controller can return a 404 payload such as
{ code, error }from/zk/lsl. The browser currently iterates every key in that payload and renderscodeanderroras child znodes.This change only turns entries with a valid ZooKeeper stat shape into tree children, so missing-node responses leave the expanded node with no fake children while real children named
codeorerrorare still preserved when their values are stat objects.Validation:
npm run build-devnpm run buildgit diff --checkcode/errorchild payloadsI also ran
npx eslint app/utils/PinotMethodUtils.ts --quiet; it still fails on existing repository lint configuration and pre-existing errors unrelated to this change.