Skip to content

Add support for selecting all segments at once for moving to different tier #17812

Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom
raghavyadav01:segment-selector-fixed-all
Mar 4, 2026
Merged

Add support for selecting all segments at once for moving to different tier #17812
Jackie-Jiang merged 2 commits intoapache:masterfrom
raghavyadav01:segment-selector-fixed-all

Conversation

@raghavyadav01
Copy link
Collaborator

commit contains changes to support FixedTierSegmentSelector: support ["*"] to select all completed segments

  • Extends the fixed segment selector so that segmentList: ["*"] selects all completed segments for a tier, instead of a fixed list of segment names.

Motivation

  • Time-based tier selection depends on a time column for segment start/end. Tables without a time column cannot use time-based tiers. This change lets such tables use tiered storage by selecting all completed segments with 0 segment Age.

Changes

  • FixedTierSegmentSelector: If segmentList contains "*", treat it as “select all completed segments” instead of matching segment names.

Testing

  • Added testFixedSegmentSelectorWithWildcardSelectsAllCompleted in TierSegmentSelectorTest.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.22%. Comparing base (61b8364) to head (32129a9).
⚠️ Report is 13 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17812      +/-   ##
============================================
- Coverage     63.27%   63.22%   -0.05%     
- Complexity     1454     1456       +2     
============================================
  Files          3185     3187       +2     
  Lines        191526   191623      +97     
  Branches      29301    29316      +15     
============================================
- Hits         121193   121163      -30     
- Misses        60855    60977     +122     
- Partials       9478     9483       +5     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (?)
java-11 55.56% <100.00%> (-7.65%) ⬇️
java-21 63.21% <100.00%> (-0.03%) ⬇️
temurin 63.22% <100.00%> (-0.05%) ⬇️
unittests 63.22% <100.00%> (-0.05%) ⬇️
unittests1 55.61% <100.00%> (+<0.01%) ⬆️
unittests2 34.12% <40.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit 3ca14f9 into apache:master Mar 4, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants