Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the log in SegmentPartitionMetadataManager #14968

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Close #14695

Aggregate the per-segment log into per-table log

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (59551e4) to head (66bd6a3).
Report is 1660 commits behind head on master.

Files with missing lines Patch % Lines
...mentpartition/SegmentPartitionMetadataManager.java 55.26% 12 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14968      +/-   ##
============================================
+ Coverage     61.75%   63.69%   +1.94%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2712     +276     
  Lines        133233   152060   +18827     
  Branches      20636    23501    +2865     
============================================
+ Hits          82274    96858   +14584     
- Misses        44911    47918    +3007     
- Partials       6048     7284    +1236     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.65% <55.26%> (+1.94%) ⬆️
java-21 63.59% <55.26%> (+1.97%) ⬆️
skip-bytebuffers-false 63.67% <55.26%> (+1.92%) ⬆️
skip-bytebuffers-true 63.57% <55.26%> (+35.85%) ⬆️
temurin 63.69% <55.26%> (+1.94%) ⬆️
unittests 63.69% <55.26%> (+1.94%) ⬆️
unittests1 56.23% <ø> (+9.34%) ⬆️
unittests2 34.01% <55.26%> (+6.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit f7e3fe9 into apache:master Feb 1, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegmentPartitionMetadataManager unbounded logging
3 participants