[timeseries] Remove Time Series Specific Code from V1 Engine #14841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsultana
added
the
timeseries-engine
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14841 +/- ##
============================================
+ Coverage 61.75% 63.76% +2.01%
- Complexity 207 1611 +1404
============================================
Files 2436 2703 +267
Lines 133233 151188 +17955
Branches 20636 23341 +2705
============================================
+ Hits 82274 96402 +14128
- Misses 44911 47551 +2640
- Partials 6048 7235 +1187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitsultana
commented
Jan 19, 2025
| /** | ||
| * Used by the leaf stage, because the leaf stage materializes tag values very late. | ||
| */ | ||
| public abstract TimeSeries buildWithTagOverrides(List<String> tagNames, Object[] tagValues); |
There was a problem hiding this comment.
@raghavyadav01 : this one change will be required in series builders. This should do the build, AND use the provided tag names and values for the new series. See other builders in this PR for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Time Series specific code from Pinot's V1 Engine, and instead leverages a Transform function and an Aggregation function to implement the leaf stage for Time Series queries.
This helps us take advantage of the speed that
GroupByOperatorandAggregationOperator, while at the same time, allows Time Series languages to define how they want their series to built.This also greatly simplifies the Time Series code, as can be seen by the fact that this PR removes a ton of code.
Series Limit Handling
Series limit are now handled via standard Group By limits as defined here.
API Changes
BaseTimeSeriesBuilderhas a new method calledbuildWithTagOverrides. This is because theGroupByOperatormaterializes Group values lazily to avoid excessive allocations.Future Work
TimeSeriesBlock, and propagate the group limit reached warning to the caller.