Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the actor that triggers the minion task #14829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shounakmk219
Copy link
Collaborator

Description

Minion task can be triggered by 3 ways as of now

  1. Cron schedule
  2. Manual schedule
  3. Adhoc task execution

To identify which actor triggered a particular task run, this PR injects the information in task configs so that it gets tracked in zk for reference.

The triggeredBy info is also made available on TaskDebugInfo and SubtaskDebugInfo.

Refactor on PinotTaskManager

There were too many derivations of schedule methods in PinotTaskManager based on what combination of tables and task types are supposed to be scheduled. This made the changes on schedule inputs hard to manage.
This PR adds a wrapper class TaskSchedulingContext that will be passed to only one scheduleTasks() method to achieve all the derivations.

@shounakmk219 shounakmk219 changed the title Track the actor that triggers the task Track the actor that triggers the minion task Jan 16, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.33%. Comparing base (59551e4) to head (79a8879).
Report is 1587 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (79a8879). Click for more details.

HEAD has 36 uploads less than BASE
Flag BASE (59551e4) HEAD (79a8879)
integration 7 0
integration2 3 0
temurin 12 5
java-21 7 2
skip-bytebuffers-true 3 1
skip-bytebuffers-false 7 4
java-11 5 3
unittests2 3 0
integration1 2 0
custom-integration1 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14829      +/-   ##
============================================
- Coverage     61.75%   56.33%   -5.42%     
- Complexity      207      795     +588     
============================================
  Files          2436     2118     -318     
  Lines        133233   113894   -19339     
  Branches      20636    18298    -2338     
============================================
- Hits          82274    64162   -18112     
+ Misses        44911    44526     -385     
+ Partials       6048     5206     -842     
Flag Coverage Δ
custom-integration1 ?
integration ?
integration1 ?
integration2 ?
java-11 56.30% <ø> (-5.41%) ⬇️
java-21 56.19% <ø> (-5.43%) ⬇️
skip-bytebuffers-false 56.32% <ø> (-5.43%) ⬇️
skip-bytebuffers-true 56.15% <ø> (+28.42%) ⬆️
temurin 56.33% <ø> (-5.42%) ⬇️
unittests 56.33% <ø> (-5.42%) ⬇️
unittests1 56.33% <ø> (+9.44%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants