Adding error message in the SchemUtils.java #14804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,7 +176,7 @@ private static void validateCompatibilityWithTableConfig(Schema schema, TableCon | |||
| } catch (Exception e) { | |||
| throw new IllegalStateException( | |||
| "Schema is incompatible with tableConfig with name: " + tableConfig.getTableName() + " and type: " | |||
| + tableConfig.getTableType(), e); | |||
| + tableConfig.getTableType()+" Caused By: "+e.getMessage(), e); | |||
There was a problem hiding this comment.
Suggested change
| + tableConfig.getTableType()+" Caused By: "+e.getMessage(), e); | |
| + tableConfig.getTableType() + ", reason: " + e.getMessage(), e); |
There was a problem hiding this comment.
Hello @Jackie-Jiang,
I have corrected the message.
siddharthteotia
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14804 +/- ##
============================================
- Coverage 61.75% 56.32% -5.43%
- Complexity 207 801 +594
============================================
Files 2436 2120 -316
Lines 133233 113795 -19438
Branches 20636 18279 -2357
============================================
- Hits 82274 64093 -18181
+ Misses 44911 44505 -406
+ Partials 6048 5197 -851
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cutiepie-10
force-pushed
the
origin/ValidationFailure
branch
from
6d57c3c to
f3b3231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an error message in the SchemaUtils.java inside the validateCompatibilityWithTableConfig(). #14787