Fix Storage Quota Utilization Metric Emission for Realtime Tables #14780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please describe how you verified the metrics are actually emitted (maybe a screenshot of the metric in jvisualvm for an integration test) |
sajjad-moradi
approved these changes
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14780 +/- ##
============================================
+ Coverage 61.75% 63.88% +2.13%
- Complexity 207 1609 +1402
============================================
Files 2436 2704 +268
Lines 133233 150929 +17696
Branches 20636 23317 +2681
============================================
+ Hits 82274 96418 +14144
- Misses 44911 47302 +2391
- Partials 6048 7209 +1161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yuyaoo
changed the title
|
Hi @Jackie-Jiang, could you help take a look at this PR too when you get a chance? Thank you! cc @sajjad-moradi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the StorageQuotaChecker to ensure that the storage quota utilization metric is emitted during realtime segment validation. Previously, the metric was skipped for segments with a size of 0, which usually indicates a realtime validation path. Now that storage quota is supported for realtime tables, we need to monitor the metric.
Related PR: Storage quota imposition on realtime tables
Testing
Tested by triggering the RealtimeSegmentValidationManager periodic task within an integration test and using VisualVM to confirm that the
tableStorageQuotaUtilizationis emitted in controller metrics.