Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6945 Update Surefire plugin to 3.0.0 and switch to TCP forkNo… #106

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Jul 25, 2023

…de implementation

@stoty stoty requested a review from richardantal July 25, 2023 08:08
@stoty
Copy link
Contributor Author

stoty commented Jul 25, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 19m 8s master passed
+1 💚 compile 1m 17s master passed
+1 💚 javadoc 0m 26s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 7m 55s the patch passed
+1 💚 compile 1m 21s the patch passed
-1 ❌ javac 1m 21s root generated 42 new + 2082 unchanged - 42 fixed = 2124 total (was 2124)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 28s root generated 42 new + 2095 unchanged - 42 fixed = 2137 total (was 2137)
_ Other Tests _
-1 ❌ unit 33m 16s root in the patch failed.
-1 ❌ asflicense 0m 8s The patch generated 3 ASF License warnings.
68m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #106
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux e708d73eb918 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 7e3bc08
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 1902 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-106/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought it looks like the maven-surefire-plugin.version is not beeing used

@stoty
Copy link
Contributor Author

stoty commented Aug 9, 2023

You are right. Thanks.

@stoty
Copy link
Contributor Author

stoty commented Aug 9, 2023

I messed up and applied the wrong patch.
I have pushed an addenum to fix the problem you have found.

@stoty stoty closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants