Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add expectNextN to StreamTestKit for javadsl. #962

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 15, 2024

Motivation:
Add an expectN method to StreamTestKit which supports java List

@He-Pin He-Pin changed the title feat: Add expectNextN to StreamTestKit. feat: Add expectNextN to StreamTestKit for javadsl. Jan 15, 2024
@He-Pin He-Pin requested a review from mdedetrich January 15, 2024 17:06
@He-Pin He-Pin added this to the 1.1.0 milestone Jan 15, 2024
@pjfanning
Copy link
Contributor

is there a test that could be added here or elsewhere in the repo that uses this method?

Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin requested a review from pjfanning January 16, 2024 05:26
@He-Pin He-Pin merged commit 9e38362 into apache:main Jan 16, 2024
18 checks passed
@He-Pin He-Pin deleted the expectN branch January 16, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants