Skip to content

Conversation

ronantakizawa
Copy link
Contributor

Fixes issue #2213

@He-Pin
Copy link
Member

He-Pin commented Sep 19, 2025

Thank you~

@He-Pin He-Pin added this to the 2.0.0-M1 milestone Sep 19, 2025
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@He-Pin
Copy link
Member

He-Pin commented Sep 19, 2025

Seems some tests failed

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI build failed. Looks like the doc build but I will need to check more fully later tonight.

@ronantakizawa
Copy link
Contributor Author

@He-Pin @pjfanning the test should pass now.

I had to change docs/src/main/paradox/actors.md and docs/src/main/paradox/stream/stream-quickstart.md to not use fiddle_code anymore

@He-Pin He-Pin requested a review from pjfanning September 20, 2025 01:50
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin
Copy link
Member

He-Pin commented Sep 20, 2025

@pjfanning It's ok now

@pjfanning pjfanning dismissed their stale review September 20, 2025 08:04

out of date

@pjfanning pjfanning merged commit 1feb26f into apache:main Sep 20, 2025
9 checks passed
@pjfanning
Copy link
Member

merged - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants