Skip to content

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Sep 13, 2025

Motivation:

Sort import to reducethe difference in other pr.

I sort it with sbt sortImports

Need a sort imports once merged

@He-Pin He-Pin added this to the 2.0.0-M1 milestone Sep 13, 2025
@He-Pin
Copy link
Member Author

He-Pin commented Sep 13, 2025

@pjfanning @mdedetrich I would like to have this get merged first, and then in the other prs,we can do sortImports

@mdedetrich
Copy link
Contributor

@He-Pin I am already sorting the imports in my PR at #2206, this is kind of pointless?

@He-Pin
Copy link
Member Author

He-Pin commented Sep 13, 2025

@mdedetrich I want to reduce the change set, merge this first and then add it to the blame ignore, and then you sort again, the change set will be much smaller.

@mdedetrich
Copy link
Contributor

mdedetrich commented Sep 13, 2025

@mdedetrich I want to reduce the change set, merge this first and then add it to the blame ignore, and then you sort again, the change set will be much smaller.

I just spent half the day manually going through and cleaning up/sorting all of the imports in all of the source files. While the changeset in my PR is big, it's just rearranging imports around.

Can I please merge my PR first so that everyone else is unblocked and free to work?

@He-Pin
Copy link
Member Author

He-Pin commented Sep 13, 2025

@mdedetrich please go ahead

@mdedetrich
Copy link
Contributor

@mdedetrich please go ahead

Thanks I will be done tonight

@He-Pin He-Pin marked this pull request as draft September 13, 2025 16:52
@He-Pin He-Pin marked this pull request as ready for review September 13, 2025 18:01
@He-Pin
Copy link
Member Author

He-Pin commented Sep 17, 2025

@pjfanning @mdedetrich, how about merging this first , this is done by sbt sortImports

@mdedetrich
Copy link
Contributor

@pjfanning @mdedetrich, how about merging this first , this is done by sbt sortImports

This is going to break all documentation imports, they have to be manually sorted (thats why its taking so long)

@He-Pin He-Pin closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants