chore: Remove pekko.util.FutureConverters #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
requested review from
pjfanning and
mdedetrich
and removed request for
pjfanning
|
@mdedetrich @pjfanning Then I think this one is ready |
|
I'm away from my computer today. If @mdedetrich approved this, I am happy to see it merged. |
|
He said we can merge if it's not related to formatting |
|
@mdedetrich this one should be ready too |
There is a conflict you need to resolve |
|
@mdedetrich resolved. |
|
@mdedetrich I think this one should be ready now. |
He-Pin
requested review from
raboof,
nvollmar,
ptrdom,
Roiocam and
laglangyue
laglangyue
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Remove pekko.util.FutureConverters