chore: Use Scala Option Converter #2203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll come back this later in the weekend. |
|
@pjfanning I'm working on the Duration one |
|
@pjfanning We should remove those two classes. |
|
I would prefer to deprecate in 2.0.0-M1 and maybe remove before full release. |
|
I think we should delete it, otherwise it will cause trouble when users import or when IDE automatically completes. |
He-Pin
force-pushed
the
scala-option-converter
branch
from
b0a4475 to
43e235a
Compare
reorder imports
He-Pin
force-pushed
the
scala-option-converter
branch
from
11ac29c to
352077f
Compare
jxnu-liguobin
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.