Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Tweak withAttributes in Flow #1658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Tweak withAttributes in Flow #1658

wants to merge 1 commit into from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 31, 2024

Motivation:

To avoid #1525 , I checked all the Flow#withAttributes usage.

Modification:
Move the .withAttributes() inside the via(...)

Result:

  1. consistent style
  2. safer when using it with graphdsl.

@He-Pin He-Pin added the t:stream Pekko Streams label Dec 31, 2024
@He-Pin He-Pin added this to the 1.2.0 milestone Dec 31, 2024
@pjfanning pjfanning changed the title chore: Tweak withAttribuets in Flow chore: Tweak withAttributes in Flow Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning Awaiting requested review from pjfanning

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@raboof raboof Awaiting requested review from raboof

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
t:stream Pekko Streams
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@He-Pin