Skip to content

Resort imports #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 20, 2025
Merged

Resort imports #791

merged 16 commits into from
Sep 20, 2025

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 18, 2025 •
edited
Loading

  • Demo of copy over sortImports from main pekko repo #790
  • I changed some of the imports so that the sortImports can handle them (usually by more fully qualifying the imports)
  • CustomMediaTypesSpec is used in our docs and none of the features that I tried that were meant to disable scalafix stopped it being processed - I think I managed to get it to a state where it still works for paradox but where scalafix has processed it

@pjfanning pjfanning marked this pull request as draft September 18, 2025 17:09
@He-Pin
Copy link
Member

He-Pin commented Sep 18, 2025

+1 for this, this will help a lot.

@pjfanning pjfanning force-pushed the resort-imports branch 2 times, most recently from 7ccbcb4 to 10d7607 Compare September 20, 2025 08:50
@pjfanning pjfanning changed the title [WIP] Resort imports Resort imports Sep 20, 2025
@pjfanning pjfanning marked this pull request as ready for review September 20, 2025 09:00
@pjfanning pjfanning requested review from raboof, mdedetrich and He-Pin and removed request for raboof September 20, 2025 12:04
@pjfanning
Copy link
Member Author

This sort is repeatable (run sbt sortImports) and doesn't break anything. It runs quickly.

If someone comes up with another sorting solution, we can add that later.

He-Pin
He-Pin reviewed Sep 20, 2025
View reviewed changes
http-tests/src/test/scala/org/apache/pekko/http/scaladsl/CustomMediaTypesSpec.scala
set.contains(MediaType.parse("application/x-akka-test").right.get) should ===(true)
set.contains(MediaType.parse("application/x-Akka-TEST").right.get) should ===(true)
set.contains(MediaType.parse("application/x-pekko-test").right.get) should ===(true)
set.contains(MediaType.parse("application/x-Pekko-TEST").right.get) should ===(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

He-Pin
He-Pin approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit a904e91 into apache:main Sep 20, 2025
6 checks passed
@He-Pin
Copy link
Member

He-Pin commented Sep 20, 2025

@pjfanning Would you think it valuable to have this in pekko-grpc too.

@pjfanning pjfanning deleted the resort-imports branch September 20, 2025 12:49
@pjfanning pjfanning mentioned this pull request Sep 20, 2025
Merged
@pjfanning
Copy link
Member Author

@pjfanning Would you think it valuable to have this in pekko-grpc too.

  • not as much code in pekko-grpc and generally, the build is more complicated (mix of sbt, mvn and gradle)
  • may not be worth the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@raboof raboof Awaiting requested review from raboof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @He-Pin