Skip to content

Java duration in javadsl #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 17, 2025
Merged

Java duration in javadsl #780

merged 14 commits into from
Sep 17, 2025

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 16, 2025 •
edited
Loading

  • targeting v1.3.0 and will forward fit to main - main is in flux due to all the 2.0.0 changes
  • I looked at the javadsl packages in this repo and found a number of classes where we use scala.duration.Duration instead of java.time.Duration in the Java DSL
  • I added overloaded methods that accept java.time.Duration where feasible.
  • There are some getXXX methods that return scala.duration.Duration - changing this is a breaking change that we can't do in 1.x - I think we should live with and fix it in 2.0.0 where we can make breaking changes
    • Adding extra methods but with names like getXXXAsJava is too messy and so far, we don't have too many complaints from users

@pjfanning pjfanning changed the base branch from main to 1.3.x September 16, 2025 02:52
@pjfanning pjfanning marked this pull request as draft September 16, 2025 02:53
@pjfanning pjfanning marked this pull request as ready for review September 16, 2025 02:53
@pjfanning pjfanning marked this pull request as draft September 16, 2025 02:53
@pjfanning pjfanning closed this Sep 16, 2025
@pjfanning pjfanning reopened this Sep 16, 2025
@pjfanning pjfanning changed the title Java duration in javadsl (pekko-http jar) Java duration in javadsl Sep 16, 2025
@pjfanning pjfanning marked this pull request as ready for review September 16, 2025 20:40
nvollmar
nvollmar approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

He-Pin
He-Pin approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 7bd9042 into apache:1.3.x Sep 17, 2025
10 checks passed
@pjfanning pjfanning deleted the java-duration-in-javadsl branch September 17, 2025 08:30
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Sep 17, 2025
@pjfanning
Java duration in javadsl (apache#780)
101e048 
* allow java durations to be used in pekko-http javadsl

* web socket settings

* Update WebSocketSettings.scala

* compile issue

* more changes

* mima

* ClientConnectionSettings

* ConnectionPoolSettings

* javafmt

* Update java-duration-support-javadsl.excludes

* imports

* Update CachingDirectivesExamplesTest.java

* examples

* update tests
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Sep 17, 2025
@pjfanning
Java duration in javadsl (apache#780)
272b346 
* allow java durations to be used in pekko-http javadsl

* web socket settings

* Update WebSocketSettings.scala

* compile issue

* more changes

* mima

* ClientConnectionSettings

* ConnectionPoolSettings

* javafmt

* Update java-duration-support-javadsl.excludes

* imports

* Update CachingDirectivesExamplesTest.java

* examples

* update tests

Update WSProbe.scala
This was referenced Sep 17, 2025
Open
Merged
pjfanning added a commit that referenced this pull request Sep 17, 2025
@pjfanning
Java duration in javadsl (#780) (#784)
340ea15 
* Java duration in javadsl (#780)

* allow java durations to be used in pekko-http javadsl

* web socket settings

* Update WebSocketSettings.scala

* compile issue

* more changes

* mima

* ClientConnectionSettings

* ConnectionPoolSettings

* javafmt

* Update java-duration-support-javadsl.excludes

* imports

* Update CachingDirectivesExamplesTest.java

* examples

* update tests

Update WSProbe.scala

* compile issues

* remove ability to pass a null java timeout
@pjfanning pjfanning mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

@nvollmar nvollmar nvollmar approved these changes

@raboof raboof Awaiting requested review from raboof

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @He-Pin @nvollmar