Skip to content

use Scala FunctionConverter and remove some unused implicits #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

use Scala FunctionConverter and remove some unused implicits #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http-caching/src/main/scala/org/apache/pekko/http/caching/LfuCache.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import java.util.function.BiFunction
import scala.concurrent.duration.Duration
import scala.concurrent.{ ExecutionContext, Future }
import scala.jdk.CollectionConverters._
import scala.jdk.FunctionConverters._
import scala.jdk.FutureConverters._

import com.github.benmanes.caffeine.cache.{ AsyncCache, Caffeine }
Expand All @@ -29,7 +30,6 @@ import pekko.http.caching.LfuCache.toJavaMappingFunction
import pekko.http.caching.scaladsl.Cache
import pekko.http.impl.util.JavaMapping.Implicits._
import pekko.http.caching.CacheJavaMapping.Implicits._
import pekko.util.FunctionConverters._

@ApiMayChange
object LfuCache {
Expand Down
1 change: 0 additions & 1 deletion ...re/src/main/scala/org/apache/pekko/http/impl/util/EnhancedByteStringTraversableOnce.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ package org.apache.pekko.http.impl.util

import org.apache.pekko
import pekko.annotation.InternalApi
import pekko.http.ccompat._
import pekko.util.ByteString

/**
Expand Down
1 change: 0 additions & 1 deletion http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/Multipart.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import java.util.concurrent.CompletionStage
import org.apache.pekko
import pekko.annotation.InternalApi
import pekko.event.LoggingAdapter
import pekko.http.ccompat._
import pekko.http.impl.engine.rendering.BodyPartRenderer
import pekko.http.impl.util.{ DefaultNoLogging, Util }
import pekko.http.impl.util.JavaMapping.Implicits._
Expand Down
17 changes: 7 additions & 10 deletions http-tests/src/multi-jvm/scala/org/apache/pekko/remote/testkit/MultiNodeConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,23 @@

package org.apache.pekko.remote.testkit

import language.implicitConversions
import java.net.{ InetAddress, InetSocketAddress }

import com.typesafe.config.{ Config, ConfigFactory, ConfigObject }

import language.implicitConversions
import scala.concurrent.{ Await, Awaitable }
import scala.util.control.NonFatal
import scala.concurrent.duration._
import scala.collection.immutable
import scala.util.control.NonFatal

import org.apache.pekko
import pekko.actor._
import pekko.util.Timeout
import pekko.http.ccompat._
import pekko.remote.testconductor.{ TestConductor, TestConductorExt }
import pekko.event.{ LogSource, Logging, LoggingAdapter }
import pekko.remote.testconductor.{ RoleName, TestConductor, TestConductorExt }
import pekko.testkit._
import pekko.testkit.TestEvent._

import scala.concurrent.duration._
import pekko.remote.testconductor.RoleName
import pekko.actor.RootActorPath
import pekko.event.{ LogSource, Logging, LoggingAdapter }
import pekko.util.Timeout

/**
* Configure the role names and participants of the test, including configuration settings.
Expand Down
1 change: 0 additions & 1 deletion .../src/main/scala/org/apache/pekko/http/javadsl/server/directives/FormFieldDirectives.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import pekko.http.scaladsl.server.{ Directives => D }
import pekko.http.scaladsl.server.directives.ParameterDirectives._

import scala.jdk.CollectionConverters._
import pekko.http.impl.util.JavaMapping.Implicits._
import scala.jdk.OptionConverters._

abstract class FormFieldDirectives extends FileUploadDirectives {
Expand Down
2 changes: 0 additions & 2 deletions http/src/main/scala/org/apache/pekko/http/javadsl/server/directives/HeaderDirectives.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import java.util.{ function => jf }

import org.apache.pekko
import pekko.actor.ReflectiveDynamicAccess

import pekko.http.impl.util.JavaMapping.Implicits._
import pekko.http.javadsl.model.headers.{ HttpOriginRange, HttpOriginRanges }
import pekko.http.javadsl.model.HttpHeader
import pekko.http.javadsl.server.Route
Expand Down
1 change: 0 additions & 1 deletion http/src/main/scala/org/apache/pekko/http/scaladsl/common/StrictForm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import scala.concurrent.{ ExecutionContext, Future }
import scala.concurrent.duration._
import org.apache.pekko
import pekko.stream.Materializer
import pekko.http.ccompat._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no error reporting, seems like we need some unused lint in this project.

import pekko.http.scaladsl.unmarshalling._
import pekko.http.scaladsl.model._
import pekko.http.scaladsl.util.FastFuture
Expand Down
1 change: 0 additions & 1 deletion http/src/main/scala/org/apache/pekko/http/scaladsl/marshalling/Marshal.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ package org.apache.pekko.http.scaladsl.marshalling

import scala.concurrent.{ ExecutionContext, Future }
import org.apache.pekko
import pekko.http.ccompat._
import pekko.http.scaladsl.server.ContentNegotiator
import pekko.http.scaladsl.model._
import pekko.http.scaladsl.util.FastFuture._
Expand Down
Loading