GH-2962: Set dictionary_page_offset even when encoding_stats are missing #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing_stats are missing
…ing_stats are missing
|
@wgtmac could you merge this ? |
|
Just merged it. Thanks @mothukur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently dictionary page offset is not being set when there are no encoding statistics. This is creating problem while creating parquet files using the addRowGroup method in ParquetMetadataConverter
What changes are included in this PR?
Set dictionary_page_offset value when column has any dictionary pages.
Are these changes tested?
Yes
Are there any user-facing changes?
No
Closes #2962