Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-781. Direct support for PathOutputCommitter #1361

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steveloughran
Copy link
Contributor

If parquet.path.outputcommitter.enabled is true
then it uses the PathOutputCommitterFactory mechanism to dynamically
choose a committer for the output path.
Such committers do not generate summary files; a warning
about this is printed when appropriate

This significantly simplifies writing to s3/azure/gcs
though committers which commit correctly and efficiently
to the target stores.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No tests yet

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

If "parquet.path.outputcommitter.enabled" is true
then it uses the PathOutputCommitterFactory mechanism to dynamically
choose a committer for the output path.
Such committers do not generate summary files; a warning
about this is printed when appropriate

This significantly simplifies writing to s3/azure/gcs
though committers which commit correctly and efficiently
to the target stores.

Change-Id: Ib443c64bbdf37f808213d46d02a4fcba2f8f1361
@steveloughran steveloughran marked this pull request as draft May 30, 2024 13:27
@steveloughran
Copy link
Contributor Author

Needs tests

Proposed: enable factory, enable summary, verify summaries are not created but the job works. manually review the output log too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant